Handle branch/jump in branch delay slots more accurately #15957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See hrydgard#15952 for more detail.
This seems cleaner, instead of the duplication of lines for each branch type.
Otherwise it tries to use deprecated ashmem and chokes.
hrydgard
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See detail in #15952. Should help the crash (not the rendering) in #7223. I assume there must be other games doing this, if there's one (but probably not many, because I haven't noticed a real case of this before outside VFPU.)
I did test a few cases on a PSP and it seems branches generally work the way the VFPU branches work, and jumps work a bit differently. I didn't check float branches specifically, but figured better to assume they work the same.
There's a bit of repeated code for the linking, although I did at least clean up x86 so it wouldn't be as bad.
-[Unknown]